Skip to content

Conversation

@elelaysh
Copy link

This reverts a change made in #440 to debug errors in rocky update workflow

changed in #440 to debug errors in rocky update workflow
@elelaysh elelaysh requested a review from a team as a code owner November 12, 2025 17:03
@elelaysh elelaysh changed the title bootstrap: restore dnf module usage to remove cockpit bootstrap: restore removing cockpit via dnf module Nov 12, 2025
@sjpb
Copy link
Collaborator

sjpb commented Nov 13, 2025

The comment on that task on #440 is:

 # N.B. using ansible dnf module is very slow

which TBH I suspect is a misunderstanding, this is the first dnf task so I suspect it is just updating the metadata. From memory this was causing problems with Azimuth/caas slurm?

However given we deliberately swapped away from the dnf module because it wasn't working for us, I'm not going to revert that without some tests demonstrating we understand and fixed the problem somewhere else.

@elelaysh
Copy link
Author

Thank you @sjpb for the review.

What I really want to fix is the task showing as changed when it is not.

We could add a dnf check-upgrade command with changed_when: false to perform the initial metadata sync.
And then the dnf module to remove cockpit which handles changed correctly.

Or we could inspect the output of dnf remove for "No package to remove" or "Nothing to do" to compute the changed_when value.

How would you suggest reproducing the issues with the dnf module?

@sjpb
Copy link
Collaborator

sjpb commented Nov 13, 2025

How would you suggest reproducing the issues with the dnf module?

I don't know tbh, this was a bit of a "quick fix" TBH!

@elelaysh elelaysh marked this pull request as draft November 14, 2025 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants